Repository navigation
DevTools standalone shell changes: - #17213
Merged
bvaughn merged 2 commits intoOct 31, 2019
Merged
Conversation
1. Update React Native connection wording 2. Tweak styles slightly
threepointone
approved these changes
Oct 29, 2019
threepointone
left a comment
threepointone
left a comment
Contributor
There was a problem hiding this comment.
Regarding the second screen; would it be a good idea to provide actionable advice? It’s not apparent it’s an error with that styling. Maybe “Please stop the other running instance” or something?
Feel free to disregard, or do in a future PR. It simply stood out to me in this one.
Contributor
Author
|
Hm. I guess we could tweak the wording a bit to say something more like:
|
Contributor
Author
|
Here. This is maybe a little better. |
trueadm
pushed a commit
to trueadm/react
that referenced
this pull request
Nov 4, 2019
* DevTools standalone shell changes: 1. Update React Native connection wording 2. Tweak styles slightly * Tweaked standalone DevTools error warning text
mrizwanashiq
pushed a commit
to mrizwanashiq/react
that referenced
this pull request
Jun 25, 2026
* DevTools standalone shell changes: 1. Update React Native connection wording 2. Tweak styles slightly * Tweaked standalone DevTools error warning text
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cosmetic changes to the RN shell:
Waiting to connect
Before
After
Error
Before
After